luhenry commented on a change in pull request #32415:
URL: https://github.com/apache/spark/pull/32415#discussion_r624673844
##########
File path: pom.xml
##########
@@ -298,6 +298,18 @@
<enabled>false</enabled>
</snapshots>
</repository>
+
+ <!-- THIS SHOULD NOT BE MERGED!!! THIS IS A TEMPORARY WORKAROUND!!! -->
Review comment:
Remove this.
##########
File path: project/SparkBuild.scala
##########
@@ -272,6 +272,8 @@ object SparkBuild extends PomBuild {
// See https://storage-download.googleapis.com/maven-central/index.html
for more info.
"gcs-maven-central-mirror" at
"https://maven-central.storage-download.googleapis.com/maven2/";,
DefaultMavenRepository,
+ // /!\ DO NOT MERGE !!! /!\
Review comment:
Remove this.
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -105,13 +105,13 @@ jobs:
key: build-${{ hashFiles('**/pom.xml', 'project/build.properties',
'build/mvn', 'build/sbt', 'build/sbt-launch-lib.bash',
'build/spark-build-info') }}
restore-keys: |
build-
- - name: Cache Coursier local repository
- uses: actions/cache@v2
- with:
- path: ~/.cache/coursier
- key: ${{ matrix.java }}-${{ matrix.hadoop }}-coursier-${{
hashFiles('**/pom.xml', '**/plugins.sbt') }}
- restore-keys: |
- ${{ matrix.java }}-${{ matrix.hadoop }}-coursier-
+ # - name: Cache Coursier local repository
Review comment:
Revert this.
##########
File path: pom.xml
##########
@@ -172,7 +172,7 @@
<fasterxml.jackson.version>2.12.2</fasterxml.jackson.version>
<snappy.version>1.1.8.4</snappy.version>
<netlib.java.version>1.1.2</netlib.java.version>
- <netlib.ludovic.dev.version>1.3.2</netlib.ludovic.dev.version>
Review comment:
Add proper `2.0.0` version.
##########
File path: pom.xml
##########
@@ -325,6 +337,17 @@
<enabled>false</enabled>
</snapshots>
</pluginRepository>
+ <!-- THIS SHOULD NOT BE MERGED!!! THIS IS A TEMPORARY WORKAROUND!!! -->
Review comment:
Remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
