HyukjinKwon commented on a change in pull request #32394:
URL: https://github.com/apache/spark/pull/32394#discussion_r624879992
##########
File path: core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala
##########
@@ -49,7 +49,11 @@ abstract class BenchmarkBase {
val resultFileName =
s"${this.getClass.getSimpleName.replace("$",
"")}$jdkString$suffix-results.txt"
val prefix = Benchmarks.currentProjectRoot.map(_ + "/").getOrElse("")
- val file = new File(s"${prefix}benchmarks/$resultFileName")
+ val dir = new File(s"${prefix}benchmarks/")
+ if (!dir.exists()) {
+ dir.mkdirs()
+ }
+ val file = new File(s"${dir}$resultFileName")
Review comment:
Ah, okay. the new benchmark were added at SPARK-33882 and SPARK-35150,
that was after https://github.com/apache/spark/pull/32015 and
https://github.com/apache/spark/pull/32044.
Okay, @byungsoo-oh, would you mind throwing an exception with `assert` here
with a pretty error message? I think the results files should always be
existent. I think the results files at SPARK-33882 and SPARK-35150 were not
mistakenly added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
