Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/5798#discussion_r29407552
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveResolutionSuite.scala
---
@@ -81,9 +81,13 @@ class HiveResolutionSuite extends HiveComparisonTest {
.toDF().registerTempTable("caseSensitivityTest")
val query = sql("SELECT a, b, A, B, n.a, n.b, n.A, n.B FROM
caseSensitivityTest")
- assert(query.schema.fields.map(_.name) === Seq("a", "b", "A", "B",
"a", "b", "A", "B"),
+ assert(query.schema.fields.map(_.name) === Seq("a", "b", "a", "b",
"a", "b", "a", "b"),
"The output schema did not preserve the case of the query.")
--- End diff --
It is no problem to normalize table name and column names. I meant, for the
case user explicitly specifies the case in the query like this test, don't we
need to preserve it in the schema of the returned df? e.g., Some databases
might use case-sensitivity enabled configuration. If we connect with it through
jdbc driver, may it cause problem?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
