fommil edited a comment on pull request #30810: URL: https://github.com/apache/spark/pull/30810#issuecomment-832481967
the f2j backend in spark is provided via netlib-java which can swap to using machine optimised binaries if they are present. There are reasons not to use netlib-java (and I no longer recommend it, preferring direct handcoded access to machine optimised libblas) so it's good to see alternatives being proposed. However, it is strange that you're not providing benchmarks against machine-optimised MKL (or otherwise) backends as described in http://fommil.com/scalax14/#/ The f2j backend is just the fallback and could be replaced in the most part (e.g. dgemm) with 10 lines of java code. Lots of benchmarks over at https://github.com/fommil/matrix-toolkits-java as another consumer of netlib-java that address your comments about "memory copying" (which is incorrect). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
