Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/5680#discussion_r29410045
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingJobProgressListener.scala
---
@@ -135,28 +132,25 @@ private[streaming] class
StreamingJobProgressListener(ssc: StreamingContext)
def receivedRecordsDistributions: Map[Int, Option[Distribution]] =
synchronized {
val latestBatchInfos = retainedBatches.reverse.take(batchInfoLimit)
- val latestBlockInfos = latestBatchInfos.map(_.receivedBlockInfo)
- (0 until numReceivers).map { receiverId =>
- val blockInfoOfParticularReceiver = latestBlockInfos.map { batchInfo
=>
- batchInfo.get(receiverId).getOrElse(Array.empty)
- }
- val recordsOfParticularReceiver = blockInfoOfParticularReceiver.map
{ blockInfo =>
- // calculate records per second for each batch
- blockInfo.map(_.numRecords).sum.toDouble * 1000 / batchDuration
- }
- val distributionOption = Distribution(recordsOfParticularReceiver)
- (receiverId, distributionOption)
+
+ // TODO. this should be fixed when receiver-less input stream is mixed
into BatchInfo
--- End diff --
This is what makes me concern a lot. Now for the `BatchInfo's
streamIdToNumRecords`, all the input stream's statistic data will be in it, not
receiver-based input stream, so do we need to differentiate the statistics?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
