cloud-fan commented on pull request #32404: URL: https://github.com/apache/spark/pull/32404#issuecomment-833173900
> For example, calling a method func(input: Object) with argument Tuple2 will be disallowed. This should be allowed, because we do provide the concrete parameter type (`Tuple2`). What should be forbidden is something like `func(s: String)` and the parameter type is `Object`. I think I get your point, we should probably use a util function to look up the method, instead of writing the code by ourselves, to handle cases like search the inheritance hierarchy, argument type casting, etc. How about https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/reflect/MethodUtils.html#getMatchingMethod-java.lang.Class-java.lang.String-java.lang.Class...- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
