maropu commented on pull request #32441: URL: https://github.com/apache/spark/pull/32441#issuecomment-833193408
I've checked the failure and I think it is not related to this PR. NOTE: I noticed that the failure happened because `tpcds/q6.sql` sorts the `cnt` column only: https://github.com/apache/spark/blob/a0c76a8755a148e2bd774edcda12fe20f2f38c75/sql/core/src/test/resources/tpcds/q6.sql#L20 Actually, `tpcds/q6.sql` and `tpcds-v2.7.0/q6.sql` are almost the same and `tpcds-v2.7.0/q6.sql` sorts both `cnt` and `a.ca_state`: https://github.com/apache/spark/blob/a0c76a8755a148e2bd774edcda12fe20f2f38c75/sql/core/src/test/resources/tpcds-v2.7.0/q6.sql#L22 So, I'm thinking that we'd be better to remove `tpcds/q6.sql` for stable testing. I'll check if the other queries have the same issue then make a PR to fix it later. Anyway, the fix itself in this PR looks fine, too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
