dongjoon-hyun commented on a change in pull request #32450:
URL: https://github.com/apache/spark/pull/32450#discussion_r627850527
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
##########
@@ -378,11 +378,17 @@ trait JoinSelectionHelper {
/**
* Matches a plan whose single partition should be small enough to build a
hash table.
*
- * Note: this assume that the number of partition is fixed, requires
additional work if it's
- * dynamic.
+ * In AQE framework, we use runtime statistics to check if we can build
local map. Only if
+ * all the partition size not large than
`ADAPTIVE_SHUFFLE_HASH_JOIN_LOCAL_MAP_THRESHOLD`,
Review comment:
`size not large` -> `size is not larger`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
