dongjoon-hyun commented on a change in pull request #32287:
URL: https://github.com/apache/spark/pull/32287#discussion_r628808070
##########
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -146,6 +151,12 @@ final class ShuffleBlockFetcherIterator(
/** Current number of blocks in flight per host:port */
private[this] val numBlocksInFlightPerAddress = new HashMap[BlockManagerId,
Int]()
+ /**
+ * Count the retry times for the blocks due to Netty OOM. The block will
stop retry if
+ * retry times has exceeded the [[maxAttemptsOnNettyOOM]].
+ */
+ private[this] val blockOOMRetryTimes = new HashMap[String, Int]
Review comment:
nit. Given the description, `Count the retry`, can we rename this to
`blockOOMRetryCounts` because `Times` can have a different meaning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
