maropu commented on a change in pull request #32482:
URL: https://github.com/apache/spark/pull/32482#discussion_r628885975



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1090,6 +1090,18 @@ object SQLConf {
       .booleanConf
       .createWithDefault(true)
 
+  val CACHE_DISABLE_CONFIGS =
+    buildConf("spark.sql.cache.disableConfigs")
+      .doc("Configurations needs to be turned off, to avoid regression for 
cached query, so that " +
+        "the outputPartitioning of the underlying cached query plan can be 
leveraged later.")

Review comment:
       I think [this 
comment](https://github.com/apache/spark/pull/32482/files#diff-88635a13b65f19dcc80b865d903b498b8328607f96c088402a8ebdbb857eedf9L61-L62)
 is for developers, so it is difficult for a user to understand it. Could you 
brush up it more?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to