c21 commented on a change in pull request #32476:
URL: https://github.com/apache/spark/pull/32476#discussion_r629729379
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
##########
@@ -353,12 +353,37 @@ case class SortMergeJoinExec(
}
}
- override def supportCodegen: Boolean = {
- joinType.isInstanceOf[InnerLike]
+ private lazy val (streamedPlan, bufferedPlan) = joinType match {
+ case _: InnerLike | LeftOuter => (left, right)
+ case RightOuter => (right, left)
+ case x =>
+ throw new IllegalArgumentException(
+ s"SortMergeJoin.streamedPlan/bufferedPlan should not take $x as the
JoinType")
Review comment:
Makes sense to me, addressed in
https://github.com/apache/spark/pull/32495 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
