[GitHub] [spark] HyukjinKwon commented on a change in pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

[GitBox]

HyukjinKwon commented on a change in pull request #32504:
URL: https://github.com/apache/spark/pull/32504#discussion_r630945116



##########
File path: 
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala
##########
@@ -253,6 +253,9 @@ private[deploy] class SparkSubmitArguments(args: 
Seq[String], env: Map[String, S
         && Try(JavaUtils.byteStringAsBytes(executorMemory)).getOrElse(-1L) <= 
0) {
       error("Executor memory must be a positive number")
     }
+    if (driverCores != null && Try(driverCores.toInt).getOrElse(-1) <= 0) {
+       error("Driver cores must be a positive number")

Review comment:
       ```suggestion
         error("Driver cores must be a positive number")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org