HyukjinKwon commented on a change in pull request #32510:
URL: https://github.com/apache/spark/pull/32510#discussion_r630952745
##########
File path:
core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala
##########
@@ -264,7 +264,9 @@ private[spark] class FallbackConfigEntry[T] (
version
) {
- override def defaultValueString: String = s"<value of ${fallback.key}>"
+ override def defaultValue: Option[T] = fallback.defaultValue
Review comment:
Hm, if the fallback is set, the default value here isn't correct anymore
.. right
##########
File path:
core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala
##########
@@ -264,7 +264,9 @@ private[spark] class FallbackConfigEntry[T] (
version
) {
- override def defaultValueString: String = s"<value of ${fallback.key}>"
+ override def defaultValue: Option[T] = fallback.defaultValue
Review comment:
Hm, if the fallback configuration is set, the default value here isn't
correct anymore .. right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
