cloud-fan commented on a change in pull request #32520:
URL: https://github.com/apache/spark/pull/32520#discussion_r631062829
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -36,6 +36,12 @@ trait TPCDSBase extends SharedSparkSession with TPCDSSchema {
"q81", "q82", "q83", "q84", "q85", "q86", "q87", "q88", "q89", "q90",
"q91", "q92", "q93", "q94", "q95", "q96", "q97", "q98", "q99")
+ // Since `tpcdsQueriesV2_7_0` has almost the same queries with these oens
below,
+ // we skip them in the TPCDS-related tests.
+ private val excludedTpcdsQueries: Set[String] = Set("q6", "q34", "q64",
"q74", "q75", "q78")
+
+ val tpcdsQueries: Seq[String] =
tpcdsAllQueries.filterNot(excludedTpcdsQueries.contains)
Review comment:
another idea:
```
val tpcdsQueries: Seq[String] = 1.to(99).map("q" + _).flatMap { q =>
if (Seq("q14", "q23", "q24", "q39").contains(q)) Seq(q + "a", q + "b")
else Seq(q)
}.filterNot { q =>
// ...
Seq("q6", "q34", "q64", "q74", "q75", "q78").contains(q)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
