sunchao commented on a change in pull request #32527:
URL: https://github.com/apache/spark/pull/32527#discussion_r631540561
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -127,13 +128,18 @@ trait InvokeLike extends Expression with NonSQLExpression
{
arguments: Seq[Expression],
input: InternalRow,
dataType: DataType): Any = {
- val args = arguments.map(e => e.eval(input).asInstanceOf[Object])
- if (needNullCheck && args.exists(_ == null)) {
+ var i = 0
+ val len = arguments.length
+ while (i < len) {
+ evaluatedArgs(i) = arguments(i).eval(input).asInstanceOf[Object]
Review comment:
Yea even though we evaluate `arguments` for each `invoke` call we can
reuse the same array to store the results of evaluation. I guess it's better
than allocating a new `Array[Object]` for each input row.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
