cloud-fan commented on a change in pull request #32553:
URL: https://github.com/apache/spark/pull/32553#discussion_r633782896



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -2204,11 +2204,12 @@ class Analyzer(override val catalogManager: 
CatalogManager)
         findMethod(scalarFunc, MAGIC_METHOD_NAME, argClasses) match {
           case Some(m) if Modifier.isStatic(m.getModifiers) =>
             StaticInvoke(scalarFunc.getClass, scalarFunc.resultType(),
-              MAGIC_METHOD_NAME, arguments, returnNullable = 
scalarFunc.isResultNullable)
+              MAGIC_METHOD_NAME, arguments, propagateNull = false,

Review comment:
       How can users handle nullable int values if the UDF is something like 
`isPositive(int i)` which can't accept null argument?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to