[GitHub] [spark] LuciferYang commented on pull request #32536: [SPARK-35398][SQL] Simplify the way to get classes from ClassBodyEvaluator in `CodeGenerator.updateAndGetCompilationStats` method

[GitBox]

LuciferYang commented on pull request #32536:
URL: https://github.com/apache/spark/pull/32536#issuecomment-842973792


   
![image](https://user-images.githubusercontent.com/1475305/118617609-5ec87c80-b7f5-11eb-94ae-f9f8a40b3f96.png)
   
   @maropu 
   
   `Reservoir` in `com.codahale.metrics.Histogram` is 
`ExponentiallyDecayingReservoir`, it's values are statistical samples, not 
complete sets, when the size of values exceeds the threshold(1028), the new 
values may not be inserted into values.
   
   I printed size of `METRIC_GENERATED_CLASS_BYTECODE_SIZE` and 
`METRIC_GENERATED_METHOD_BYTECODE_SIZE` in 
   `CodeGenerationSuite.beforeAll` method, their results are all 1028.
   
   So this case will fail  when run 
   
   ```
   mvn test -pl sql/catalyst
   ```
   
   and this case will success  when run 
   
   ```
   mvn test -pl sql/catalyst 
-DwildcardSuites=org.apache.spark.sql.catalyst.expressions.CodeGenerationSuite
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org