cloud-fan commented on pull request #32542: URL: https://github.com/apache/spark/pull/32542#issuecomment-843013396
I think there are 2 options we can pick: 1. Have a single `AlterTable` logical plan, which has 2 members: `table: LogicalPlan` and `changes: Seq[TableChange]`. We also have a single `AlterTableExec` physical plan. 2. Have various `AlterTableXXX` logical plans, which are similar to the existing `AlterTableXXXStatement`. Update the code that resolve/check `Seq[TableChange]` to deal with `AlterTableXXX` logical plans instead. We still have a single `AlterTableExec` physical plan, the planner will convert all `AlterTableXXX` logical plans to it. @imback82 what do you think? I feel option 1 is a smaller change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
