linhongliu-db commented on a change in pull request #32587:
URL: https://github.com/apache/spark/pull/32587#discussion_r635776715
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionInfo.java
##########
@@ -144,6 +155,11 @@ public ExpressionInfo(
this.name + "]. It should be a value in " + validGroups + ";
however, " +
"got [" + group + "].");
}
+ if (!language.isEmpty() && !validLanguages.contains(language)) {
Review comment:
how about we change this to `functionType`, and use "scala_udf",
"java_udf", "python_udf", "built-in", "hive". Because using empty to indicate
builtin is a little bit risky assumption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
