sarutak commented on a change in pull request #32632:
URL: https://github.com/apache/spark/pull/32632#discussion_r637375021
##########
File path:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerKrbJDBCIntegrationSuite.scala
##########
@@ -178,19 +178,7 @@ abstract class DockerKrbJDBCIntegrationSuite extends
DockerJDBCIntegrationSuite
.option("keytab", keytabFullPath)
.option("principal", principal)
.option("refreshKrb5Config", "true")
- .option("query", "SELECT 1")
- .load()
- }
-
- // Set the authentic krb5.conf but doesn't refresh config
- // so this assertion is expected to fail.
- intercept[Exception] {
Review comment:
If `refreshKrb5Config` is not set to true, whether `krb5.conf` is read
or not when a new connection is established can depend on the implementation
for each JDBC driver.
We can remove the assertion because the remaining two assertion are
important.
The second assertion ensure that `refreshKrb5Config` enforces to refresh.
##########
File path:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerKrbJDBCIntegrationSuite.scala
##########
@@ -178,19 +178,7 @@ abstract class DockerKrbJDBCIntegrationSuite extends
DockerJDBCIntegrationSuite
.option("keytab", keytabFullPath)
.option("principal", principal)
.option("refreshKrb5Config", "true")
- .option("query", "SELECT 1")
- .load()
- }
-
- // Set the authentic krb5.conf but doesn't refresh config
- // so this assertion is expected to fail.
- intercept[Exception] {
Review comment:
If `refreshKrb5Config` is not set to true, whether `krb5.conf` is read
or not when a new connection is established can depend on the implementation
for each JDBC driver.
We can remove the assertion because the remaining two assertion are
important.
The second assertion ensures that `refreshKrb5Config` enforces to refresh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
