cloud-fan commented on a change in pull request #32599:
URL: https://github.com/apache/spark/pull/32599#discussion_r638092851
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
##########
@@ -325,6 +328,36 @@ class JacksonParser(
parseJsonToken[AnyRef](parser,
dataType)(PartialFunction.empty[JsonToken, AnyRef])
}
+ def makeKeyConverter(dataType: DataType): KeyConverter = dataType match {
Review comment:
I think it's different from `makeConverter`, as the JSON key is always
string: `{"key": value}`.
That said, I'm not sure if this feature makes sense. If we turn a JSON
string into a map, the key type should always be string type. Users can run
`transform_keys` function to cast the key string to whatever data type they
want.
We should probably improve the error message though, if a user specifies a
MapType with non-string key type. cc @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
