otterc commented on a change in pull request #32140:
URL: https://github.com/apache/spark/pull/32140#discussion_r640321817
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -720,7 +720,7 @@ private[spark] class MapOutputTrackerMaster(
}
}
- def registerMergeResult(shuffleId: Int, reduceId: Int, status: MergeStatus) {
+ def registerMergeResult(shuffleId: Int, reduceId: Int, status: MergeStatus):
Unit = {
Review comment:
Note to reviewers: this was added as part of push-based shuffle so just
fixing the below warning:
```
[warn]
/home/runner/work/spark/spark/core/src/main/scala/org/apache/spark/MapOutputTracker.scala:723:79:
[deprecation @ | origin= | version=2.13.0] procedure syntax is deprecated:
instead, add `: Unit =` to explicitly declare `registerMergeResult`'s return
type
[warn] def registerMergeResult(shuffleId: Int, reduceId: Int, status:
MergeStatus) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
