HyukjinKwon commented on a change in pull request #32631:
URL: https://github.com/apache/spark/pull/32631#discussion_r640573670



##########
File path: dev/sparktestsupport/modules.py
##########
@@ -743,6 +743,20 @@ def __hash__(self):
     ]
 )
 
+docker_integration_tests = Module(
+    name="docker-integration-tests",
+    dependencies=[],
+    build_profile_flags=["-Pdocker-integration-tests"],
+    source_file_regexes=["external/docker-integration-tests"],
+    sbt_test_goals=["docker-integration-tests/test"],
+    environ={
+        "ENABLE_DOCKER_INTEGRATION_TESTS": "1"
+    },

Review comment:
       @sarutak, I just read 
https://github.com/apache/spark/pull/32631#discussion_r640427313. Can we add 
this environment variable if `GITHUB_ACTION` environment variable is set? e.g.)
   
   ```suggestion
       # Run Docker integration tests only in GitHub Actions because Jenkins 
doesn't have Docker.
       environ=None if "GITHUB_ACTIONS" not in os.environ else {
           "ENABLE_DOCKER_INTEGRATION_TESTS": "1"
       },
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to