allisonwang-db commented on a change in pull request #32303:
URL: https://github.com/apache/spark/pull/32303#discussion_r641255370
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/joinTypes.scala
##########
@@ -107,6 +107,11 @@ case class UsingJoin(tpe: JoinType, usingColumns:
Seq[String]) extends JoinType
override def sql: String = "USING " + tpe.sql
}
+case class LateralJoin(tpe: JoinType) extends JoinType {
+ require(Seq(Inner, LeftOuter, Cross).contains(tpe), "Unsupported lateral
join type " + tpe)
Review comment:
@maropu Postgres supports INNER, CROSS, and LEFT lateral join, and it
doesn't make sense to support RIGHT OUTER and FULL OUTER lateral join. How
about let's add the other two types of supported left joins: left semi and left
anti here. Then lateral join types shouldn't be changed in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
