cloud-fan commented on a change in pull request #32687:
URL: https://github.com/apache/spark/pull/32687#discussion_r641329643
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
##########
@@ -62,11 +62,13 @@ abstract class PlanExpression[T <: QueryPlan[_]] extends
Expression {
*/
abstract class SubqueryExpression(
plan: LogicalPlan,
- children: Seq[Expression],
- exprId: ExprId) extends PlanExpression[LogicalPlan] {
+ outerAttrs: Seq[Expression],
+ exprId: ExprId,
+ joinCond: Seq[Expression] = Nil) extends PlanExpression[LogicalPlan] {
override lazy val resolved: Boolean = childrenResolved && plan.resolved
override lazy val references: AttributeSet =
Review comment:
We can remove this now, as the default impl is
`AttributeSet.fromAttributeSets(children.map(_.references))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
