cloud-fan commented on a change in pull request #32699:
URL: https://github.com/apache/spark/pull/32699#discussion_r642258870
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##########
@@ -1068,11 +1072,19 @@ class CodegenContext extends Logging {
}.unzip
val splitThreshold = SQLConf.get.methodSplitThreshold
- val codes = if (commonExprVals.map(_.code.length).sum > splitThreshold) {
+
+ val (codes, subExprsMap, exprCodes) = if
(nonSplitExprCode.map(_.length).sum > splitThreshold) {
if
(inputVarsForAllFuncs.map(calculateParamLengthFromExprValues).forall(isValidParamLength))
{
- commonExprs.zipWithIndex.map { case (exprs, i) =>
+ val localSubExprEliminationExprs =
+ mutable.HashMap.empty[Expression, SubExprEliminationState]
+
+ val splitCodes = commonExprs.zipWithIndex.map { case (exprs, i) =>
val expr = exprs.head
- val eval = commonExprVals(i)
+ val eval =
withSubExprEliminationExprs(localSubExprEliminationExprs.toMap) {
+ Seq(expr.genCode(this))
+ }.head
+
+ val value = addMutableState(javaType(expr.dataType), "subExprValue")
Review comment:
why does this have to be a mutable state now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
