viirya commented on a change in pull request #32735:
URL: https://github.com/apache/spark/pull/32735#discussion_r643721483
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -1134,9 +1134,9 @@ case class HashedRelationBroadcastMode(key:
Seq[Expression], isNullAware: Boolea
sizeHint: Option[Long]): HashedRelation = {
sizeHint match {
case Some(numRows) =>
- HashedRelation(rows, canonicalized.key, numRows.toInt, isNullAware =
isNullAware)
+ HashedRelation(rows, key, numRows.toInt, isNullAware = isNullAware)
case None =>
- HashedRelation(rows, canonicalized.key, isNullAware = isNullAware)
+ HashedRelation(rows, key, isNullAware = isNullAware)
Review comment:
I'm not sure why we use canonicalized key here. We don't do comparison
but use the key to project key rows later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
