xuechendi commented on pull request #32743: URL: https://github.com/apache/spark/pull/32743#issuecomment-853109731
> OK I'm fine with doing in synchronously - I was afraid that closing the objects could be expensive, and, is best-effort in any event, so made sense to do asynchronously. I see, either way is OK to me, and I personally felt non-blocking makes more sense, since these objects will be released eventually, just like other GCable objects stored in MemoryStore, they are also released asynchronously by GC instead of releasing immediately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
