[GitHub] [spark] mridulm commented on a change in pull request #30691: [SPARK-32920][SHUFFLE] Finalization of Shuffle push/merge with Push based shuffle and preparation step for the reduce stage

[GitBox]

mridulm commented on a change in pull request #30691:
URL: https://github.com/apache/spark/pull/30691#discussion_r645055803



##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -737,25 +737,26 @@ private[spark] class MapOutputTrackerMaster(
   }
 
   /**
-   * Unregisters a merge result corresponding to the reduceId if present. If 
the optional mapId
-   * is specified, it will only unregister the merge result if the mapId is 
part of that merge
+   * Unregisters a merge result corresponding to the reduceId if present. If 
the optional mapIndex
+   * is specified, it will only unregister the merge result if the mapIndex is 
part of that merge
    * result.
    *
    * @param shuffleId the shuffleId.
    * @param reduceId  the reduceId.
    * @param bmAddress block manager address.
-   * @param mapId     the optional mapId which should be checked to see it was 
part of the merge
-   *                  result.
+   * @param mapIndex  the optional mapIndex which should be checked to see it 
was part of the
+   *                  merge result.
    */
   def unregisterMergeResult(
     shuffleId: Int,
     reduceId: Int,
     bmAddress: BlockManagerId,
-    mapId: Option[Int] = None) {
+    mapIndex: Option[Int] = None) {
     shuffleStatuses.get(shuffleId) match {
       case Some(shuffleStatus) =>
         val mergeStatus = shuffleStatus.mergeStatuses(reduceId)
-        if (mergeStatus != null && (mapId.isEmpty || 
mergeStatus.tracker.contains(mapId.get))) {
+        if (mergeStatus != null &&
+          (mapIndex.isEmpty || mergeStatus.tracker.contains(mapIndex.get))) {
           shuffleStatus.removeMergeResult(reduceId, bmAddress)

Review comment:
       This was actually for `unregisterAllMergeResult` below - ended up 
commenting at wrong line.
   But this is required, let me resolve this comment thread.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org