Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5842#discussion_r29528275
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
    @@ -28,6 +28,20 @@ import org.apache.spark.sql.execution.stat.FrequentItems
     final class DataFrameStatFunctions private[sql](df: DataFrame) {
     
       /**
    +   * Computes a pair-wise frequency table of the given columns. Also known 
as a contingency table.
    +   * The number of distinct values for each column should be less than 
Int.MaxValue. The first
    --- End diff --
    
    We won't be able to handle `Int.MaxValue - 1`, which is still too large. 
Maybe we should say the number of distinct value pairs cannot be too large.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to