HeartSaVioR commented on a change in pull request #32828:
URL: https://github.com/apache/spark/pull/32828#discussion_r647905898
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
##########
@@ -274,6 +274,9 @@ class SymmetricHashJoinStateManager(
if (valuePairAtMaxIndex != null) {
keyWithIndexToValue.put(currentKey, index,
valuePairAtMaxIndex.value,
valuePairAtMaxIndex.matched)
+ } else {
+ logWarning(s"`keyWithIndexToValue` returns a null value for index
${numValues - 1} " +
Review comment:
The reason I suggested to log a warning message here is to help
debugging if the problem arises.
Suppose we see the log message and would like to understand what's
happening. Does it give enough information, with other logs? Can we determine
the current key from the log context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
