cloud-fan commented on a change in pull request #32786:
URL: https://github.com/apache/spark/pull/32786#discussion_r648062679
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/CollectMetricsExec.scala
##########
@@ -33,8 +35,65 @@ case class CollectMetricsExec(
child: SparkPlan)
extends UnaryExecNode {
+ /**
+ * The specific implementation of AggregatingAccumulator for calling `merge`
on executor side.
+ */
+ private class MetricsAggregatingAccumulator(
Review comment:
Does it worth the complexity? Where do we use `AggregatingAccumulator`
except for `CollectMetricsExec`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
