gengliangwang opened a new pull request #32843:
URL: https://github.com/apache/spark/pull/32843


   ### What changes were proposed in this pull request?
   Add `TimestampWithoutTZType` to `DataTypeTestUtils.ordered`/`atomicTypes`, 
and implement values generation of those types in 
`LiteralGenerator`/`RandomDataGenerator`. In this way, the types will be tested 
automatically in:
   1. ArithmeticExpressionSuite:
       - "function least"
       - "function greatest"
   2. PredicateSuite
       - "BinaryComparison consistency check"
       - "AND, OR, EqualTo, EqualNullSafe consistency check"
   3. ConditionalExpressionSuite
       - "if"
   4. RandomDataGeneratorSuite
       - "Basic types"
   5. CastSuite
       - "null cast"
       - "up-cast"
       - "SPARK-27671: cast from nested null type in struct"
   6. OrderingSuite
       - "GenerateOrdering with TimestampWithoutTZType"
   7. PredicateSuite
       - "IN with different types"
   8. UnsafeRowSuite
       - "calling get(ordinal, datatype) on null columns"
   9. SortSuite
       - "sorting on TimestampWithoutTZType ..."
   
   ### Why are the changes needed?
   To improve test coverage.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   By running the affected test suites.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to