MaxGekk commented on a change in pull request #32839:
URL: https://github.com/apache/spark/pull/32839#discussion_r648300427
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -385,9 +385,16 @@ object DateTimeUtils {
* microseconds where microsecond 0 is 1970-01-01 00:00:00Z.
*/
def instantToMicros(instant: Instant): Long = {
- val us = Math.multiplyExact(instant.getEpochSecond, MICROS_PER_SECOND)
- val result = Math.addExact(us, NANOSECONDS.toMicros(instant.getNano))
- result
+ val secs = instant.getEpochSecond
+ if (secs == Math.floorDiv(Long.MinValue, MICROS_PER_SECOND)) {
+ val us = Math.multiplyExact(secs + 1, MICROS_PER_SECOND)
+ val result = Math.addExact(us, NANOSECONDS.toMicros(instant.getNano) -
MICROS_PER_SECOND)
Review comment:
Are you making some assumption about `instant.getNano`? See the assert
the code for intervals:
https://github.com/apache/spark/blob/2c8ced95905b8a9f7b98c4913a385d25da455e7a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala#L877-L879
Should we have similar assert here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
