cloud-fan commented on a change in pull request #32841:
URL: https://github.com/apache/spark/pull/32841#discussion_r648338063
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/hints.scala
##########
@@ -30,7 +30,8 @@ import
org.apache.spark.sql.catalyst.trees.TreePattern.{TreePattern, UNRESOLVED_
case class UnresolvedHint(name: String, parameters: Seq[Any], child:
LogicalPlan)
extends UnaryNode {
- override lazy val resolved: Boolean = false
+ override lazy val resolved: Boolean = child.resolved
Review comment:
To make up for this change, let's add a check in `CheckAnalysis` and
fail if the plan still contains `UnresolvedHint` after analysis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
