[GitHub] [spark] cloud-fan commented on a change in pull request #32862: [SPARK-35695][SQL] Collect observed metrics from cached sub-tree

[GitBox]

cloud-fan commented on a change in pull request #32862:
URL: https://github.com/apache/spark/pull/32862#discussion_r649355437



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/CollectMetricsExec.scala
##########
@@ -89,8 +90,10 @@ object CollectMetricsExec {
    */
   def collect(plan: SparkPlan): Map[String, Row] = {
     val metrics = plan.collectWithSubqueries {
-      case collector: CollectMetricsExec => collector.name -> 
collector.collectedMetrics
+      case collector: CollectMetricsExec => Map(collector.name -> 
collector.collectedMetrics)
+      case tableScan: InMemoryTableScanExec =>

Review comment:
       are there more boundary nodes? how about `QueryStageExec`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org