srowen commented on a change in pull request #32877:
URL: https://github.com/apache/spark/pull/32877#discussion_r649945268
##########
File path: core/src/main/scala/org/apache/spark/ContextCleaner.scala
##########
@@ -188,7 +188,7 @@ private[spark] class ContextCleaner(
private def keepCleaning(): Unit = Utils.tryOrStopSparkContext(sc) {
while (!stopped) {
try {
- val reference =
Option(referenceQueue.remove(ContextCleaner.REF_QUEUE_POLL_TIMEOUT))
+ val reference = Option(referenceQueue.remove())
Review comment:
Hm, the issue is that remove() blocks indefinitely, so this would never
let it check `stopped` again if nothing is in the queue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
