dgd-contributor commented on a change in pull request #32863:
URL: https://github.com/apache/spark/pull/32863#discussion_r649742427



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -1161,6 +1161,28 @@ class Dataset[T] private[sql](
       throw new AnalysisException("Invalid join type in joinWith: " + 
joined.joinType.sql)
     }
 
+    // If auto self join alias is enable
+    if (sqlContext.conf.dataFrameSelfJoinAutoResolveAmbiguity) {

Review comment:
       yes, it's repeated from join function, I have created a new function and 
replaced duplicated code with it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to