MaxGekk commented on a change in pull request #32849:
URL: https://github.com/apache/spark/pull/32849#discussion_r649832808
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
##########
@@ -75,7 +75,7 @@ object CatalystTypeConverters {
case LongType => LongConverter
case FloatType => FloatConverter
case DoubleType => DoubleConverter
- case DayTimeIntervalType => DurationConverter
+ case _: DayTimeIntervalType => DurationConverter
Review comment:
Here is the JIRA: https://issues.apache.org/jira/browse/SPARK-35726
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -2550,7 +2550,7 @@ case class SubtractTimestamps(
override def inputTypes: Seq[AbstractDataType] = Seq(TimestampType,
TimestampType)
override def dataType: DataType =
- if (legacyInterval) CalendarIntervalType else DayTimeIntervalType
+ if (legacyInterval) CalendarIntervalType else DayTimeIntervalType()
Review comment:
Here, any interval types that ends to SECOND works. Why not the default
one: INTERVAL DAY TO SECOND?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
