srowen commented on a change in pull request #32907:
URL: https://github.com/apache/spark/pull/32907#discussion_r651170422
##########
File path:
common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilterImpl.java
##########
@@ -220,6 +220,35 @@ public BloomFilter mergeInPlace(BloomFilter other) throws
IncompatibleMergeExcep
return this;
}
+ @Override
+ public BloomFilter intersectInPlace(BloomFilter other) throws
IncompatibleMergeException {
+ // Duplicates the logic of `isCompatible` here to provide better error
message.
+ if (other == null) {
Review comment:
I wonder if we can just factor out these checks into a separate private
utility method, to avoid the duplication?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
