beliefer commented on a change in pull request #32916:
URL: https://github.com/apache/spark/pull/32916#discussion_r651614603
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
##########
@@ -224,7 +224,7 @@ private[sql] object CatalogV2Util {
update: StructField => Option[StructField]): StructType = {
val pos = struct.getFieldIndex(fieldNames.head)
- .getOrElse(throw new IllegalArgumentException(s"Cannot find field:
${fieldNames.head}"))
Review comment:
ditto
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
##########
@@ -236,15 +236,15 @@ private[sql] object CatalogV2Util {
case (Seq("key"), map @ MapType(keyType, _, _)) =>
val updated = update(StructField("key", keyType, nullable = false))
- .getOrElse(throw new IllegalArgumentException(s"Cannot delete map
key"))
Review comment:
ditto
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
##########
@@ -236,15 +236,15 @@ private[sql] object CatalogV2Util {
case (Seq("key"), map @ MapType(keyType, _, _)) =>
val updated = update(StructField("key", keyType, nullable = false))
- .getOrElse(throw new IllegalArgumentException(s"Cannot delete map
key"))
+ .getOrElse(throw QueryExecutionErrors.cannotDelete("map key"))
Some(field.copy(dataType = map.copy(keyType = updated.dataType)))
case (Seq("key", names @ _*), map @ MapType(keyStruct: StructType, _,
_)) =>
Some(field.copy(dataType = map.copy(keyType = replace(keyStruct,
names, update))))
case (Seq("value"), map @ MapType(_, mapValueType, isNullable)) =>
val updated = update(StructField("value", mapValueType, nullable =
isNullable))
- .getOrElse(throw new IllegalArgumentException(s"Cannot delete map
value"))
Review comment:
ditto
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
##########
@@ -254,7 +254,7 @@ private[sql] object CatalogV2Util {
case (Seq("element"), array @ ArrayType(elementType, isNullable)) =>
val updated = update(StructField("element", elementType, nullable =
isNullable))
- .getOrElse(throw new IllegalArgumentException(s"Cannot delete
array element"))
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
