cloud-fan commented on a change in pull request #32918: URL: https://github.com/apache/spark/pull/32918#discussion_r651896891
########## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/AnsiCastSuiteBase.scala ########## @@ -0,0 +1,481 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions + +import java.time.DateTimeException + +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.util.DateTimeTestUtils +import org.apache.spark.sql.internal.SQLConf +import org.apache.spark.sql.types._ +import org.apache.spark.unsafe.types.UTF8String + +abstract class AnsiCastSuiteBase extends CastSuiteBase { + + private def testIntMaxAndMin(dt: DataType): Unit = { + assert(Seq(IntegerType, ShortType, ByteType).contains(dt)) + Seq(Int.MaxValue + 1L, Int.MinValue - 1L).foreach { value => + checkExceptionInExpression[ArithmeticException](cast(value, dt), "overflow") + checkExceptionInExpression[ArithmeticException](cast(Decimal(value.toString), dt), "overflow") + checkExceptionInExpression[ArithmeticException]( + cast(Literal(value * 1.5f, FloatType), dt), "overflow") + checkExceptionInExpression[ArithmeticException]( + cast(Literal(value * 1.0, DoubleType), dt), "overflow") + } + } + + private def testLongMaxAndMin(dt: DataType): Unit = { + assert(Seq(LongType, IntegerType).contains(dt)) + Seq(Decimal(Long.MaxValue) + Decimal(1), Decimal(Long.MinValue) - Decimal(1)).foreach { value => + checkExceptionInExpression[ArithmeticException]( + cast(value, dt), "overflow") + checkExceptionInExpression[ArithmeticException]( + cast((value * Decimal(1.1)).toFloat, dt), "overflow") + checkExceptionInExpression[ArithmeticException]( + cast((value * Decimal(1.1)).toDouble, dt), "overflow") + } + } + + test("ANSI mode: Throw exception on casting out-of-range value to byte type") { Review comment: we can override the `test` method in `AnsiCastSuiteBase` to automatically add the "ANSI mode:" prefix in the test name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
