HeartSaVioR commented on a change in pull request #32914: URL: https://github.com/apache/spark/pull/32914#discussion_r652223432
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala ########## @@ -319,15 +319,7 @@ class SymmetricHashJoinStateManager( keyWithIndexToValueMetrics.numKeys, // represent each buffered row only once keyToNumValuesMetrics.memoryUsedBytes + keyWithIndexToValueMetrics.memoryUsedBytes, keyWithIndexToValueMetrics.customMetrics.map { - case (s @ StateStoreCustomSumMetric(_, desc), value) => Review comment: If we are also considering extension point from outside (like 3rd party state store provider) to add a new implementation of `StateStoreCustomMetric`, we should definitely not suppose the new implementation to be a case class having `desc` as field. (Even they have it, we can't use unless doing reflection.) I think this is the right way to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org