JkSelf commented on a change in pull request #32921:
URL: https://github.com/apache/spark/pull/32921#discussion_r654224713
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -96,6 +96,7 @@ case class AdaptiveSparkPlanExec(
@transient private val queryStageOptimizerRules: Seq[Rule[SparkPlan]] = Seq(
PlanAdaptiveDynamicPruningFilters(this),
ReuseAdaptiveSubquery(context.subqueryCache),
+ PrepareScans,
Review comment:
@cloud-fan `PlanAdaptiveDynamicPruningFilters ` rule will add the DPP
filter subquery and then the subquery will be executed when calling the
`prepare()` method in `FileScan `operator. Here if adding the `PrepareScans
`rule, the DPP filter subquery will be executed in this rule. I think there
should be no problem that the DPP filter subquery is executed in the
`PrepareScans `rule. Please correct me if I don't understand your question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
