cloud-fan commented on a change in pull request #32881:
URL: https://github.com/apache/spark/pull/32881#discussion_r654156008
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1192,6 +1192,13 @@ object SQLConf {
.createWithDefault(
"org.apache.spark.sql.execution.datasources.SQLHadoopMapReduceCommitProtocol")
+ val FILE_NAMING_PROTOCOL_CLASS =
+ buildConf("spark.sql.sources.namingProtocolClass")
Review comment:
I agree that the file naming shouldn't be part of commit protocol, but I
think the callers in Spark should decide the file name, like file format
writer, or something similar for hive tables, not users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
