cloud-fan commented on a change in pull request #32868:
URL: https://github.com/apache/spark/pull/32868#discussion_r654190470
##########
File path:
core/src/main/scala/org/apache/spark/deploy/worker/WorkerWatcher.scala
##########
@@ -45,7 +50,14 @@ private[spark] class WorkerWatcher(
private val expectedAddress = RpcAddress.fromURIString(workerUrl)
private def isWorker(address: RpcAddress) = expectedAddress == address
- private def exitNonZero() = if (isTesting) isShutDown = true else
System.exit(-1)
+ private def exitNonZero() =
+ if (isTesting) {
+ isShutDown = true
+ } else {
+ ThreadUtils.awaitResult(Future {
Review comment:
This is more like a temporary workaround: if we hit the dead lock, we
exist after 5 seconds. Is there a way to fully eliminate the dead lock so that
we never hit it here?
cc @rednaxelafx @jiangxb1987 @Ngone51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
