cloud-fan commented on a change in pull request #32831:
URL: https://github.com/apache/spark/pull/32831#discussion_r655105481
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -846,6 +846,14 @@ class SessionCatalog(
case None => fromCatalogTable(viewInfo.tableMeta, isTempView = true)
}
+ private def buildViewDDL(metadata: CatalogTable, isTempView: Boolean):
String = {
+ val temp = if (isTempView) "TEMP" else ""
+ val viewName = metadata.identifier.toString
+ val viewText = metadata.viewText
+ val viewColumns = metadata.schema.fieldNames.mkString(", ")
+ s"CREATE OR REPLACE $temp VIEW $viewName ($viewColumns) AS $viewText"
Review comment:
we can generate `ALTER VIEW`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
