Peng-Lei commented on a change in pull request #33056:
URL: https://github.com/apache/spark/pull/33056#discussion_r657712009
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -153,7 +153,13 @@ object Literal {
def fromObject(obj: Any): Literal = new Literal(obj,
ObjectType(obj.getClass))
def create(v: Any, dataType: DataType): Literal = {
- Literal(CatalystTypeConverters.convertToCatalyst(v), dataType)
+ dataType match {
+ case _: YearMonthIntervalType if v.isInstanceOf[Period] =>
+ Literal(CatalystTypeConverters.createToCatalystConverter(dataType)(v),
dataType)
+ case _: DayTimeIntervalType if v.isInstanceOf[Duration] =>
+ Literal(CatalystTypeConverters.createToCatalystConverter(dataType)(v),
dataType)
+ case _ => Literal(CatalystTypeConverters.convertToCatalyst(v), dataType)
+ }
Review comment:
I don't think so. When I debug the `val r = Literal.create(duration,
dt)`, `r.dateType` is right. dt is the day-time intervals of any fields or
year-month intervals of any fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
