aokolnychyi commented on a change in pull request #32921:
URL: https://github.com/apache/spark/pull/32921#discussion_r658936118
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala
##########
@@ -66,10 +71,33 @@ object PartitionPruning extends Rule[LogicalPlan] with
PredicateHelper with Join
}
case _ => None
}
+ case (resExp, r @ DataSourceV2ScanRelation(_, scan:
SupportsDynamicFiltering, _)) =>
+ val filterAttrs = AttributeSet(resolveRefs(r, scan.filterAttributes))
Review comment:
@sunchao, it looks like we always fail if partition columns cannot be
resolved in the branch above this one. While it does seem safer not to fail the
query if a filter attribute cannot be resolved, shall we be consistent with v1
tables? What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
