zsxwing commented on a change in pull request #33065:
URL: https://github.com/apache/spark/pull/33065#discussion_r658337777
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
##########
@@ -492,13 +525,15 @@ case class StreamingDeduplicateExec(
true
} else {
// Drop duplicated rows
+ droppedDuplicateRowsCount += 1
Review comment:
It's better to use `numDroppedDuplicateRows += 1` directly so that it
will be sent back to driver periodically and updated on the UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
